Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable console in RelWithDebInfo configuration #1090

Closed
wants to merge 1 commit into from

Conversation

PTKay
Copy link
Member

@PTKay PTKay commented Mar 6, 2025

This PR disables the console for builds that are done in the RelWithDebInfo configuration, which make them behave closer to builds made in the Release configuration.

@DarioSamo
Copy link
Contributor

The console has been very useful and some users have reported things they've seen on the console already. Unless a logging method is implemented for those messages, I think we're better off with the console in this configuration.

@DeaTh-G
Copy link
Contributor

DeaTh-G commented Mar 6, 2025

I do think that could be important for the future to have something like as it could be helpful similar to

That said it needs more careful consideration than just turning it off completely as it the console is tremendously useful alongside a release build with debug info.

@PTKay
Copy link
Member Author

PTKay commented Mar 6, 2025

I made this change locally for myself in order to help me debug my crashing issue as I couldn't get it to crash and I suspected it had something to do with the console showing up in this configuration. As time went on though, I still can't get it to crash even without the console so it feels like #882 is just incredibly random and will be a bit of a pain to debug.

With all that said and with your thoughts in consideration, feel free to reject this pull request.

@PTKay PTKay closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants