Feature/clear cart btn #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karmyshkov
approved these changes
Dec 26, 2023
Karmyshkov
reviewed
Dec 26, 2023
src/contexts/cart-context.tsx
Outdated
| }; | ||
| successText: { | ||
| loadCartData: string; | ||
| updateCart: string; | ||
| deleteCart: string; | ||
| clearCart: string; |
There was a problem hiding this comment.
error и successText идет полное дублирование кода
There was a problem hiding this comment.
вынес повторяющийся код в общий тип
src/contexts/cart-context.tsx
Outdated
| setError((prev) => { | ||
| return { ...prev, clearCart: error.errors }; | ||
| }); | ||
| console.log('Error clearing cart:', error); |
There was a problem hiding this comment.
PR нужно чистить от console.log)
There was a problem hiding this comment.
удалил ненужные console.log
| }); | ||
| }; | ||
|
|
||
| const clearCart = () => { |
There was a problem hiding this comment.
можно сократить до:
Suggested change
| const clearCart = () => { | |
| const clearCart = () => { | |
| api | |
| .usersShoppingCartDeleteAll() | |
| .then(({ message }) => { | |
| loadCartData(); | |
| setSuccessText((prev) => ({ ...prev, clearCart: message })); | |
| }) | |
| .catch(({ errors }) => setError((prev) => ({ ...prev, clearCart: errors }))); | |
| }; |
src/services/api.ts
Outdated
| body: JSON.stringify(data), | ||
| }); | ||
| } | ||
| // usersShoppingCartRead(userId: string, id: number) { |
There was a problem hiding this comment.
Закомментированный код лучше убирать если он не нужен. Если может пригодиться, нужно оставить TODO комментарий
There was a problem hiding this comment.
удалил, т.к. скорее всего не пригодится
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183
implement button clearing cart