Feature/category on main page #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karmyshkov
approved these changes
Dec 26, 2023
Karmyshkov
reviewed
Dec 26, 2023
|
|
||
| const findNumbersToShow = useCallback(() => { | ||
| if (isMobileScreen) { | ||
| setNumberToShow(6); |
There was a problem hiding this comment.
Можно return вместе с сеттером написать:
Suggested change
| setNumberToShow(6); | |
| return setNumberToShow(6); |
| }; | ||
|
|
||
| useEffect(() => { | ||
| api.categoriesList().then((categories) => setCategories(categories)); |
There was a problem hiding this comment.
Можно сократить:
Suggested change
| api.categoriesList().then((categories) => setCategories(categories)); | |
| api.categoriesList().then(setCategories); |
| return ( | ||
| <> | ||
| <div className={styles.link}> | ||
| <TitleArrowLink title="Каталог" link="/catalog/" /> |
There was a problem hiding this comment.
Чтобы не плодить обертки у компонента "TitleArrowLink" можно добавить props classnames и получить что-то вроде этого:
Suggested change
| <TitleArrowLink title="Каталог" link="/catalog/" /> | |
| <TitleArrowLink title="Каталог" link="/catalog/" classnames={styles.link} /> |
В компоненте "TitleArrowLink" нужно будет доработать логику маленько:
Suggested change
| <TitleArrowLink title="Каталог" link="/catalog/" /> | |
| const TitleArrowLink: React.FC<TitleArrowLinkProps> = ({ title, link, type, classnames }) => { | |
| return ( | |
| <Link to={link} className={cn(styles.link, classnames)}> | |
| <p | |
| className={clsx( | |
| styles.link__title, | |
| type === 'catalogPage' && styles.link__title_type_smallFont | |
| )} | |
| > | |
| {title} | |
| </p> | |
| <ArrowIcon | |
| className={clsx( | |
| styles.link__arrow, | |
| type === 'catalogPage' && styles.link__arrow_type_small | |
| )} | |
| /> | |
| </Link> | |
| ); | |
| }; |
| <p className={styles.catalogPromo__text} onClick={handleCategoryToggle}> | ||
| {numberToShow < 12 ? 'Развернуть' : 'Свернуть'} | ||
| </p> | ||
| <span |
There was a problem hiding this comment.
Не верный элемент, нужно заменить на button. С клавиатуры не возможно будет сфокусироваться на этом элементе, почитай про доступность (https://developer.mozilla.org/ru/docs/Learn/Accessibility/HTML)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179
change old catalog component on main page to new one