Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor base HTTP client to enable request limits to work #67

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

akalex
Copy link
Member

@akalex akalex commented Jan 17, 2024

No description provided.

@akalex akalex requested a review from ndmytro January 17, 2024 09:17
@akalex akalex self-assigned this Jan 17, 2024
@akalex akalex linked an issue Jan 17, 2024 that may be closed by this pull request
@akalex akalex requested a review from Gera3dartist January 17, 2024 09:28
Fix property `_client` to cover closed connection.
async_firebase/base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ndmytro ndmytro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalex akalex merged commit cea753c into master Jan 17, 2024
17 checks passed
@akalex akalex deleted the feature/ISSUE-66-Limits-have-no-effect branch January 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Limits has no effect?
2 participants