Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec unittest #1243

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add spec unittest #1243

wants to merge 11 commits into from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Feb 6, 2025

Motivation

This PR is to improve unit test coverage for the spec module. Most tests were generated using Cline.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (b8a1a26) to head (8ddea90).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1243      +/-   ##
==========================================
+ Coverage   90.87%   91.34%   +0.47%     
==========================================
  Files          42       42              
  Lines        9537     9537              
  Branches     1926     1926              
==========================================
+ Hits         8667     8712      +45     
+ Misses        576      542      -34     
+ Partials      294      283      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel marked this pull request as draft February 6, 2025 16:41
@oruebel oruebel marked this pull request as ready for review February 6, 2025 17:55
@oruebel oruebel requested review from mavaylon1 and rly February 6, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant