Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Zarr optional for testing #1141

Merged
merged 12 commits into from
Jul 5, 2024
Merged

Make Zarr optional for testing #1141

merged 12 commits into from
Jul 5, 2024

Conversation

mavaylon1
Copy link
Contributor

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

After discussions with the team, we decided to have the zarr be an optional dependency.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.84%. Comparing base (8917eaf) to head (83defba).
Report is 29 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1141      +/-   ##
==========================================
+ Coverage   88.78%   88.84%   +0.05%     
==========================================
  Files          45       45              
  Lines        9782     9786       +4     
  Branches     2778     2778              
==========================================
+ Hits         8685     8694       +9     
+ Misses        780      776       -4     
+ Partials      317      316       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

@rly We don't currently cover the else statement in append data. The gap in this PR is the same else statment, but under the zarr conditional. Are you okay with this gap in coverage for now?

@mavaylon1 mavaylon1 marked this pull request as ready for review July 1, 2024 18:19
@mavaylon1 mavaylon1 self-assigned this Jul 1, 2024
@mavaylon1 mavaylon1 requested a review from rly July 1, 2024 18:19
@mavaylon1
Copy link
Contributor Author

@rly made a simple example. It has full coverage and covers the missing spot I mentioned from prior to this PR. It's not a actual iterable class since it does not have iter or next, but I think it is fine.

@mavaylon1 mavaylon1 requested a review from stephprince July 4, 2024 03:23
mavaylon1 and others added 2 commits July 5, 2024 12:11
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
@mavaylon1
Copy link
Contributor Author

@stephprince done

@mavaylon1 mavaylon1 enabled auto-merge (squash) July 5, 2024 19:24
@mavaylon1 mavaylon1 merged commit 62edbe4 into dev Jul 5, 2024
29 checks passed
@mavaylon1 mavaylon1 deleted the zarr_opt branch July 5, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants