Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr append for datasets (non-reference) #1136

Merged
merged 15 commits into from
Jun 28, 2024
Merged

Zarr append for datasets (non-reference) #1136

merged 15 commits into from
Jun 28, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Jun 27, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

This supports appending to zarr arrays. This does not cover the edge case for dataset of references. This has the base tests for append_data. There are more tests (TBD) in hdmf-zarr that incorporate the full IO process.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@mavaylon1 mavaylon1 changed the title Zarr append Zarr append for datasets (non-reference) Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (7426275) to head (57a0981).
Report is 28 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1136      +/-   ##
==========================================
- Coverage   88.79%   88.78%   -0.02%     
==========================================
  Files          45       45              
  Lines        9774     9778       +4     
  Branches     2776     2777       +1     
==========================================
+ Hits         8679     8681       +2     
- Misses        778      780       +2     
  Partials      317      317              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1 mavaylon1 marked this pull request as ready for review June 28, 2024 14:56
@mavaylon1 mavaylon1 requested a review from stephprince June 28, 2024 14:57
@mavaylon1 mavaylon1 self-assigned this Jun 28, 2024
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion otherwise looks good to me!

@mavaylon1 mavaylon1 enabled auto-merge (squash) June 28, 2024 23:22
@mavaylon1 mavaylon1 merged commit 539ecf4 into dev Jun 28, 2024
28 of 29 checks passed
@mavaylon1 mavaylon1 deleted the zarr_minor_append branch June 28, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants