-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr append for datasets (non-reference) #1136
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1136 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.02%
==========================================
Files 45 45
Lines 9774 9778 +4
Branches 2776 2777 +1
==========================================
+ Hits 8679 8681 +2
- Misses 778 780 +2
Partials 317 317 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small suggestion otherwise looks good to me!
Co-authored-by: Steph Prince <[email protected]>
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
This supports appending to zarr arrays. This does not cover the edge case for dataset of references. This has the base tests for append_data. There are more tests (TBD) in hdmf-zarr that incorporate the full IO process.
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?