-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning #1116
Fix warning #1116
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1116 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 45 45
Lines 9760 9760
Branches 2771 2771
=======================================
Hits 8659 8659
Misses 779 779
Partials 322 322 ☔ View full report in Codecov by Sentry. |
Review Notes: Update: It seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container changes look good to me. What was the reason for removing the .yaml
files?
They don't really need to be there since they can be generated when running the documentation. |
Got it, would it make sense to add them to the |
Done. The failing hdmf-zarr test is also on schedule and seems to be unrelated to this PR. |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Fixed the warning regarding the TermSetWrapper being already wrapped. This shouldn't be raised when a configuration is not loaded.
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?