Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage call, don't install in editable mode in testing #1107

Merged
merged 8 commits into from
May 1, 2024
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 29, 2024

Motivation

Follow-up to NeurodataWithoutBorders/nwbinspector#450 (comment)

https://setuptools.pypa.io/en/latest/userguide/development_mode.html says

Editable installs are not a perfect replacement for regular installs in a test environment. When in doubt, please test your projects as installed via a regular wheel. There are tools in the Python ecosystem, like tox or nox, that can help you with that (when used with appropriate configuration).

We use editable installs in testing in a couple places, mostly to help coverage find the sources, but we can configure that in pyproject.toml instead.

How to test the behavior?

Run all GitHub actions

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (3146c97) to head (9be854b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1107   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files          45       45           
  Lines        9745     9745           
  Branches     2767     2767           
=======================================
  Hits         8644     8644           
  Misses        779      779           
  Partials      322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly added category: enhancement improvements of code or code behavior topic: testing issues related to testing labels Apr 29, 2024
@rly rly added this to the 3.14.0 milestone Apr 29, 2024
@rly rly marked this pull request as ready for review April 29, 2024 21:49
@rly rly requested a review from mavaylon1 April 29, 2024 21:49
@rly rly changed the title Don't install in editable/develop mode during testing Update coverage call, don't install in editable mode in testing Apr 29, 2024
@rly rly merged commit 126bdb1 into dev May 1, 2024
28 checks passed
@rly rly deleted the no_editable branch May 1, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior topic: testing issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants