Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound Dataset Support for TermSetWrapper #1061

Merged
merged 53 commits into from
Apr 4, 2024
Merged

Compound Dataset Support for TermSetWrapper #1061

merged 53 commits into from
Apr 4, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Mar 3, 2024

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Add the ability to wrap compound data. This only supports one field in the compound type. (first step)

Fix #938

TODO:

  • Update documentation/tutorials
  • Update tests

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@mavaylon1 mavaylon1 added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users labels Mar 3, 2024
@mavaylon1 mavaylon1 added this to the Next Release milestone Mar 3, 2024
@mavaylon1 mavaylon1 self-assigned this Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.68%. Comparing base (244d17a) to head (da0dcd3).
Report is 45 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1061      +/-   ##
==========================================
+ Coverage   88.65%   88.68%   +0.02%     
==========================================
  Files          45       45              
  Lines        9717     9740      +23     
  Branches     2760     2768       +8     
==========================================
+ Hits         8615     8638      +23     
  Misses        778      778              
  Partials      324      324              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

Notes:

  1. Do we test for append/extend for compound data? Can't find it.

@mavaylon1 mavaylon1 requested a review from rly March 11, 2024 15:18
@mavaylon1 mavaylon1 marked this pull request as ready for review March 11, 2024 15:18
@rly
Copy link
Contributor

rly commented Mar 11, 2024

@mavaylon1 can you add a test for appending to a VectorData with a compound type array?

Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check the failing coverage test where opt reqs=true? Why is it failing?

@mavaylon1 mavaylon1 requested a review from rly March 28, 2024 05:14
Copy link
Contributor Author

@mavaylon1 mavaylon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the dim of the array cover both compound data and arrays that have the same dimension.

@mavaylon1 mavaylon1 enabled auto-merge (squash) March 28, 2024 16:14
@mavaylon1
Copy link
Contributor Author

Can you please check the failing coverage test where opt reqs=true? Why is it failing?

Done @rly

@mavaylon1 mavaylon1 requested a review from rly April 4, 2024 02:47
@mavaylon1 mavaylon1 merged commit d85d0cb into dev Apr 4, 2024
26 of 27 checks passed
@mavaylon1 mavaylon1 deleted the compound branch April 4, 2024 07:57
@rly rly removed this from the 3.14.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: TermSet Restructure (Stage 5): Compound Data
2 participants