-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compound Dataset Support for TermSetWrapper #1061
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1061 +/- ##
==========================================
+ Coverage 88.65% 88.68% +0.02%
==========================================
Files 45 45
Lines 9717 9740 +23
Branches 2760 2768 +8
==========================================
+ Hits 8615 8638 +23
Misses 778 778
Partials 324 324 ☔ View full report in Codecov by Sentry. |
Notes:
|
Co-authored-by: Ryan Ly <[email protected]>
@mavaylon1 can you add a test for appending to a VectorData with a compound type array? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please check the failing coverage test where opt reqs=true? Why is it failing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the dim of the array cover both compound data and arrays that have the same dimension.
Done @rly |
Motivation
What was the reasoning behind this change? Please explain the changes briefly.
Add the ability to wrap compound data. This only supports one field in the compound type. (first step)
Fix #938
TODO:
How to test the behavior?
Checklist
CHANGELOG.md
with your changes?