Pass near_n and far_n as an argument #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I noticed that the near and far plane distances of the view frustum were hardcoded in
auxillary.h. This meant that theznearandzfarvalues were not considered by the rasterizer's visibility condition.I modified the code so that these values are no longer constants but are instead passed as arguments. Additionally, I noticed a commented-out line in the visibility condition (
in_frustuminauxillary.h). Uncommenting this line should make the renderer filter out Gaussians which are not in the view frustum, potentially increasing the rendering speed.There is a minor change required in the 2D-Gaussian splatting repository to accommodate this PR. I created a companion PR, that you may find here.
Below, you can find some newly possible cropped renders: