Merge master into feature/amazonqLSP

hayemaxi · Feb 11, 2025 · b1a396c · b1a396c
2 parents 65daa2e + f738715
commit b1a396c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/packages/core/src/auth/providers/credentialsProviderManager.ts b/packages/core/src/auth/providers/credentialsProviderManager.ts
@@ -3,10 +3,11 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import { oneDay } from '../../shared/datetime'
 import { getLogger } from '../../shared/logger/logger'
 import { AwsLoadCredentials, telemetry } from '../../shared/telemetry/telemetry'
 import { withTelemetryContext } from '../../shared/telemetry/util'
-import { cancellableDebounce } from '../../shared/utilities/functionUtils'
+import { debounce } from '../../shared/utilities/functionUtils'
 import {
     asString,
     CredentialsProvider,
@@ -26,13 +27,13 @@ export class CredentialsProviderManager {
     private readonly providerFactories: CredentialsProviderFactory[] = []
     private readonly providers: CredentialsProvider[] = []
 
-    @withTelemetryContext({ name: 'getAllCredentialsProvider', class: credentialsProviderManagerClassName, emit: true })
+    @withTelemetryContext({ name: 'getAllCredentialsProvider', class: credentialsProviderManagerClassName })
     public async getAllCredentialsProviders(): Promise<CredentialsProvider[]> {
         let providers: CredentialsProvider[] = []
 
         for (const provider of this.providers) {
             if (await provider.isAvailable()) {
-                telemetry.aws_loadCredentials.emit({
+                void this.emitWithDebounce({
                     credentialSourceId: credentialsProviderToTelemetryType(
                         provider.getCredentialsId().credentialSource
                     ),
@@ -61,10 +62,7 @@ export class CredentialsProviderManager {
 
         return providers
     }
-    private emitWithDebounce = cancellableDebounce(
-        (m: AwsLoadCredentials) => telemetry.aws_loadCredentials.emit(m),
-        100
-    ).promise
+    private emitWithDebounce = debounce((m: AwsLoadCredentials) => telemetry.aws_loadCredentials.emit(m), oneDay)
     /**
      * Returns a map of `CredentialsProviderId` string-forms to object-forms,
      * from all credential sources. Only available providers are returned.

diff --git a/packages/core/src/test/techdebt.test.ts b/packages/core/src/test/techdebt.test.ts
@@ -39,11 +39,4 @@ describe('tech debt', function () {
         // This is relevant for the use of `fs.cpSync` in the copyFiles scripts.
         assert.ok(semver.lt(minNodejs, '18.0.0'), 'with node18+, we can remove the dependency on @types/node@18')
     })
-
-    it('remove debugging telemetry', async function () {
-        fixByDate(
-            '2025-02-11',
-            'Remove debugging telemetry in `packages/core/src/auth/providers/credentialsProviderManager.ts`. Should only need to remove the `emit: true` in the decorator.'
-        )
-    })
 })