-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify mining fees #1068
Simplify mining fees #1068
Conversation
4e4bbc5
to
2f45742
Compare
desktop/src/main/java/haveno/desktop/main/funds/withdrawal/WithdrawalView.java
Outdated
Show resolved
Hide resolved
2f45742
to
c0f4726
Compare
Please let me know when this is ready for review. Thanks. |
My bad! 🙏 Ready 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it's working well. Just some minor tweaks requested.
desktop/src/main/java/haveno/desktop/main/funds/withdrawal/WithdrawalView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/haveno/desktop/main/funds/withdrawal/WithdrawalView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/haveno/desktop/main/funds/withdrawal/WithdrawalView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/haveno/desktop/main/funds/withdrawal/WithdrawalView.java
Show resolved
Hide resolved
c0f4726
to
3596ac8
Compare
Updated! |
400c1d1
to
f24ec98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing! Sorry I'm not very familiar with it 😅 |
f24ec98
to
9e7e063
Compare
@woodser fixed! Look better now 💪 |
I made some minor modifications, so the amount entered is always the amount received, unless max is clicked, then it sends the max possible when the tx is created. Please review and merge my PR into your branch to update your open PR: sraver#1 |
I also modified the link to be centered using |
send entered amount unless max enabled
@woodser merged. Nice addition 💯 |
@sraver Please post or DM an address for payment :) |
Related to #1033
Overview
The two radio toggle are replaced by a single button.
Solution
A single button is positioned by the side of the amount input box. When clicked, the amount gets set to the maximum available, and the input simply says "MAX".
The amount can be manipulated, as long as the output amount equals the maximum available, the fees will be substracted from it.
Otherwise, the fees are paid apart.