Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify mining fees #1068

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Simplify mining fees #1068

merged 4 commits into from
Jun 30, 2024

Conversation

sraver
Copy link
Contributor

@sraver sraver commented Jun 23, 2024

Related to #1033

Overview

The two radio toggle are replaced by a single button.

Solution

A single button is positioned by the side of the amount input box. When clicked, the amount gets set to the maximum available, and the input simply says "MAX".

The amount can be manipulated, as long as the output amount equals the maximum available, the fees will be substracted from it.

Otherwise, the fees are paid apart.

@sraver sraver requested a review from woodser as a code owner June 23, 2024 15:14
@sraver sraver force-pushed the feat/simplify-fees branch 3 times, most recently from 4e4bbc5 to 2f45742 Compare June 25, 2024 01:37
@sraver sraver force-pushed the feat/simplify-fees branch from 2f45742 to c0f4726 Compare June 25, 2024 14:50
@woodser
Copy link
Contributor

woodser commented Jun 27, 2024

Please let me know when this is ready for review. Thanks.

@sraver
Copy link
Contributor Author

sraver commented Jun 27, 2024

Please let me know when this is ready for review. Thanks.

My bad! 🙏

Ready 🫡

@sraver sraver requested a review from woodser June 27, 2024 15:57
Copy link
Contributor

@woodser woodser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's working well. Just some minor tweaks requested.

@sraver sraver force-pushed the feat/simplify-fees branch from c0f4726 to 3596ac8 Compare June 28, 2024 03:06
@sraver sraver requested a review from woodser June 28, 2024 03:06
@sraver
Copy link
Contributor Author

sraver commented Jun 28, 2024

Updated!

@sraver sraver force-pushed the feat/simplify-fees branch 2 times, most recently from 400c1d1 to f24ec98 Compare June 28, 2024 03:11
Copy link
Contributor

@woodser woodser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The hyperlink is currently aligned with the top of the amount box. Can you please align in the middle?

image

@sraver
Copy link
Contributor Author

sraver commented Jun 28, 2024

Thanks. The hyperlink is currently aligned with the top of the amount box. Can you please align in the middle?

Sure thing! Sorry I'm not very familiar with it 😅

@sraver sraver force-pushed the feat/simplify-fees branch from f24ec98 to 9e7e063 Compare June 28, 2024 16:23
@sraver
Copy link
Contributor Author

sraver commented Jun 28, 2024

@woodser fixed! Look better now 💪

@woodser
Copy link
Contributor

woodser commented Jun 29, 2024

I made some minor modifications, so the amount entered is always the amount received, unless max is clicked, then it sends the max possible when the tx is created.

Please review and merge my PR into your branch to update your open PR: sraver#1

@woodser
Copy link
Contributor

woodser commented Jun 29, 2024

I also modified the link to be centered using hBox.setAlignment(Pos.CENTER_LEFT); instead of manually adding padding, which scales differently with different resolutions.

send entered amount unless max enabled
@sraver
Copy link
Contributor Author

sraver commented Jun 29, 2024

@woodser merged.

Nice addition 💯

@woodser woodser merged commit c3b93b6 into haveno-dex:master Jun 30, 2024
6 checks passed
@woodser
Copy link
Contributor

woodser commented Jun 30, 2024

@sraver Please post or DM an address for payment :)

@sraver sraver deleted the feat/simplify-fees branch June 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants