Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselect payment account currencies and countries by default #1066

Closed
wants to merge 1 commit into from

Conversation

wp07e
Copy link
Contributor

@wp07e wp07e commented Jun 23, 2024

This is an initial "follow-up" for #1030.

I, very "sillily", thought this was a one-line code change but it turns out I was very foolish.

Anyhow, I ran many different kinds of test cases on this one for about 10 mins. That included:

  1. Creating payment accounts.
  2. Creating multiple payment accounts.
  3. Making sure payment accounts persisted selected currencies.
  4. Making sure after "SELL" or "BUY" buttons are pressed and "create new offer" button, UI reflects selected currencies particularly for the drop-down box. NOTE: There is one small bug where sometimes during the same session or after a restart, the selected currency for a multi-currency account when trying to create a "SELL" or "BUY" offer will be blank. In that case, all you need to do is select you desired currency and that change will persist until you add a new payment account or restart (in some cases). But this is not a functional issue and does not effect the application in any meaningful way (although it would be nice to fix it)
  5. Making sure everything is still configured correct after a restart.
  6. Restarting multiple times with different payment accounts (new added / some deleted).
  7. Deleting an existing payment account then recreating the same payment account but with different currencies.
  8. Running through the above cases randomly.

The only thing I have not tested is whether this works on the stage net which I am "pretty" sure it will since all changes seem to be user-side only.

Keep in mind that these changes only affect most of the Traditional Currency accounts. It does not effect Crypto Currency account nor other non-standard accounts.

@wp07e wp07e requested a review from woodser as a code owner June 23, 2024 08:51
@woodser
Copy link
Contributor

woodser commented Jun 23, 2024

This doesn't seem right. The UI already remembers if the checkboxes are checked or unchecked. The only thing that needs changed is the default state when the payment account is being created.

@woodser woodser changed the title Follow-up for https://github.com/haveno-dex/haveno/pull/1030 Unselect payment account currencies and countries by default Jun 23, 2024
@wp07e
Copy link
Contributor Author

wp07e commented Jun 23, 2024

Hummm... darn... you know its quite possible that my original "one-line" changes caused the condition that you mentioned in the other pull request and that was my bases for going down this road.

Wow. Well, at least I learned more about the application! Let me start over without my initial change and go from there

@wp07e
Copy link
Contributor Author

wp07e commented Jun 23, 2024

Yep! Defeated by my own bug! lol

Ok, I will submit another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants