fix error on shut down updating p2p connections table

haveno-dex · Jul 1, 2024 · 8ce91aa · 8ce91aa
1 parent c01d634
commit 8ce91aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/core/src/main/java/haveno/core/api/XmrConnectionService.java b/core/src/main/java/haveno/core/api/XmrConnectionService.java
@@ -99,6 +99,7 @@ public final class XmrConnectionService {
     private MoneroDaemonInfo lastInfo;
     private Long syncStartHeight = null;
     private TaskLooper daemonPollLooper;
+    @Getter
     private boolean isShutDownStarted;
     private List<MoneroConnectionManagerListener> listeners = new ArrayList<>();
 

diff --git a/desktop/src/main/java/haveno/desktop/main/settings/network/NetworkSettingsView.java b/desktop/src/main/java/haveno/desktop/main/settings/network/NetworkSettingsView.java
@@ -107,7 +107,7 @@ public class NetworkSettingsView extends ActivatableView<GridPane, Void> {
     private final ClockWatcher clockWatcher;
     private final WalletsSetup walletsSetup;
     private final P2PService p2PService;
-    private final XmrConnectionService connectionManager;
+    private final XmrConnectionService connectionService;
 
     private final ObservableList<P2pNetworkListItem> p2pNetworkListItems = FXCollections.observableArrayList();
     private final SortedList<P2pNetworkListItem> p2pSortedList = new SortedList<>(p2pNetworkListItems);
@@ -131,7 +131,7 @@ public class NetworkSettingsView extends ActivatableView<GridPane, Void> {
     @Inject
     public NetworkSettingsView(WalletsSetup walletsSetup,
                                P2PService p2PService,
-                               XmrConnectionService connectionManager,
+                               XmrConnectionService connectionService,
                                Preferences preferences,
                                XmrNodes xmrNodes,
                                FilterManager filterManager,
@@ -141,7 +141,7 @@ public NetworkSettingsView(WalletsSetup walletsSetup,
         super();
         this.walletsSetup = walletsSetup;
         this.p2PService = p2PService;
-        this.connectionManager = connectionManager;
+        this.connectionService = connectionService;
         this.preferences = preferences;
         this.xmrNodes = xmrNodes;
         this.filterManager = filterManager;
@@ -303,10 +303,10 @@ public void activate() {
 
         rescanOutputsButton.setOnAction(event -> GUIUtil.rescanOutputs(preferences));
 
-        moneroPeersSubscription = EasyBind.subscribe(connectionManager.peerConnectionsProperty(),
+        moneroPeersSubscription = EasyBind.subscribe(connectionService.peerConnectionsProperty(),
                 this::updateMoneroPeersTable);
 
-        moneroBlockHeightSubscription = EasyBind.subscribe(connectionManager.chainHeightProperty(),
+        moneroBlockHeightSubscription = EasyBind.subscribe(connectionService.chainHeightProperty(),
                 this::updateChainHeightTextField);
 
         nodeAddressSubscription = EasyBind.subscribe(p2PService.getNetworkNode().nodeAddressProperty(),
@@ -503,6 +503,7 @@ private void applyPreventPublicXmrNetwork() {
     }
 
     private void updateP2PTable() {
+        if (connectionService.isShutDownStarted()) return; // ignore if shutting down
         p2pPeersTableView.getItems().forEach(P2pNetworkListItem::cleanup);
         p2pNetworkListItems.clear();
         p2pNetworkListItems.setAll(p2PService.getNetworkNode().getAllConnections().stream()