Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sysmacros.h include for GNU/Hurd #12

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

sthibaul
Copy link
Contributor

@sthibaul sthibaul commented Oct 8, 2024

No description provided.

@andreasabel
Copy link
Member

@sthibaul Thanks for the PR, Samuel.

Could you provide some evidence along with that change? CI is neutral about it.
How about some documentation of the __GNU__ flag or some article explaining it (and thus arguing for the correctness)?

@sthibaul
Copy link
Contributor Author

sthibaul commented Oct 11, 2024

Could you provide some evidence along with that change

The upstream header is at

https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/mach/hurd/bits/sysmacros.h;h=04ab5ad09abbd4274582a6af20e27b544b8a30c9;hb=HEAD

__GNU__

This is specified in the porting guidelines, in the GNU specific #define section:
https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
(yes, __GNU__ is defined on GNU/Hurd only, as it was from the start to be "the" GNU system)

@andreasabel
Copy link
Member

andreasabel commented Oct 11, 2024

Thanks!

Release candidate: https://hackage.haskell.org/package/unix-compat-0.7.3/candidate

@andreasabel andreasabel added this to the 0.7.3 milestone Oct 11, 2024
@andreasabel andreasabel self-assigned this Oct 11, 2024
@andreasabel andreasabel added the bug Something isn't working label Oct 11, 2024
@andreasabel andreasabel merged commit 0fb3cf2 into haskell-pkg-janitors:main Oct 11, 2024
27 checks passed
@andreasabel
Copy link
Member

Published as 0.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants