Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature=alloc build #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

m5p3nc3r
Copy link

@m5p3nc3r m5p3nc3r commented Apr 6, 2022

No description provided.

@m5p3nc3r
Copy link
Author

m5p3nc3r commented Apr 6, 2022

Hi Guys

I was trying to use this crate with a rp2040 project I am working on. I noticed that it was failing with "--no-default-features --features=alloc". I believe this PR fixes the problem.

Should I also add configuration to the test running to build the 'alloc' feature version of the crate?

@m5p3nc3r
Copy link
Author

m5p3nc3r commented Apr 6, 2022

Thanks for enabling the actions to be run.
Do you know what version of the rust compiler is used by the ubuntu-latest? The tests all pass when building locally using rustc 1.59.0.

@m5p3nc3r
Copy link
Author

m5p3nc3r commented Apr 6, 2022

Interestingly, for me, master branch is failing in the same way on my local machine

Assuming that master branch was working before, I have updated
the configuration to ignore new clippy warnings.

Signed-off-by: Matt Spencer <[email protected]>
@m5p3nc3r
Copy link
Author

m5p3nc3r commented Apr 6, 2022

I have updated the clippy configuration to ignore the new linting falures (apart from the double quoted single char which I have fixed).
Hope this works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants