UI: Use timestamp.now() in custom messages #29525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
commented
Feb 7, 2025
| @@ -46,11 +49,14 @@ module('Integration | Component | messages/page/create-and-edit', function (hook | |||
| assert.dom(CUSTOM_MESSAGES.field('message')).exists(); | |||
| assert.dom('[data-test-kv-key="0"]').exists(); | |||
| assert.dom('[data-test-kv-value="0"]').exists(); | |||
| assert.dom(CUSTOM_MESSAGES.input('startTime')).exists(); | |||
hellobontempo
commented
Feb 7, 2025
| assert | ||
| .dom(CUSTOM_MESSAGES.input('startTime')) | ||
| .hasValue(format(addDays(startOfDay(timestamp.now()), 1), datetimeLocalStringFormat)); | ||
| assert.dom(CUSTOM_MESSAGES.input('endTime')).exists(); |
drivera258
reviewed
Feb 7, 2025
ui/tests/integration/components/config-ui/messages/page/create-and-edit-test.js
Show resolved
Hide resolved
drivera258
approved these changes
Feb 7, 2025
hellobontempo
deleted the
ui/VAULT-33866/fix-timestamp-custom-messages
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces
new Date()withtimestamp.now()which can be more reliable stubbed in tests. See #19521 for more context✅ enterprise tests (because of timezone weirdness, double checked enterprise tests by opening a PR to the enterprise repo)
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.