Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate handling rotation job register/deregister for plugins #29505

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

robmonte
Copy link
Member

@robmonte robmonte commented Feb 5, 2025

Description

Adds helper methods for easier development when adding automated root rotation support to plugins.

Also updates AWS secrets to use these new helpers and moves the RotateCredential handler into a separate method.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@robmonte robmonte requested review from a team as code owners February 5, 2025 00:10
@robmonte robmonte requested a review from armon February 5, 2025 00:10
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Feb 5, 2025

CI Results:
All Go tests succeeded! ✅

kpcraig
kpcraig previously approved these changes Feb 5, 2025
Copy link
Contributor

@kpcraig kpcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fields part looks good - aws does too, but I'll let @vinay-gopalan give it a closer look.

@robmonte robmonte added this to the 1.19.0-rc milestone Feb 5, 2025
@robmonte robmonte removed the request for review from armon February 5, 2025 21:26
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had some small questions

sdk/helper/automatedrotationutil/fields.go Outdated Show resolved Hide resolved
sdk/helper/automatedrotationutil/fields.go Outdated Show resolved Hide resolved
sdk/helper/automatedrotationutil/fields.go Outdated Show resolved Hide resolved
sdk/helper/automatedrotationutil/fields.go Outdated Show resolved Hide resolved
sdk/helper/automatedrotationutil/fields.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants