Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated PodSecurityPolicy resource and update PersistentVolumeClaim handling #2621

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

JaylonmcShan03
Copy link
Contributor

Description

This pr removes the depreicated PodSecurityPolicy resource and fixes PersistentVolumeClaim resource handling.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner November 15, 2024 23:59
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.31.2 test is failing because of kind being on v0.23. We'll need to make another PR that updates the version to be v0.25 since that's where we can use v1.31.2

All other versions are passing which is great! It means we don't need to worry about any other breaking changes coming from upstream k8s apart from this one.

I'll approve this but can you make a PR that updates the kind version? That PR will be opened on main.

@JaylonmcShan03 JaylonmcShan03 merged commit 89a16b6 into v3-major-release Nov 16, 2024
17 of 19 checks passed
@JaylonmcShan03 JaylonmcShan03 deleted the remove-pod-security-policy branch November 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants