Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial configuration for the new resource #2505

Closed
wants to merge 12 commits into from

Conversation

JaylonmcShan03
Copy link
Contributor

@JaylonmcShan03 JaylonmcShan03 commented May 23, 2024

Description

Creating initial Configuration for the new resource kubernetes_secret_v1_data
fixes #2233

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

(base) ┌─(~/Dev/terraform-provider-kubernetes)─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────(mau@mau-JKDT676NCP:s002)─┐
└─(11:55:30 on secretV1Data)──> make testacc TESTARGS='-run TestAccKubernetesSecretV1Data_empty'                                                                                                                                                                                        ──(Thu,Oct17)─┘
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -vet=off -run TestAccKubernetesSecretV1Data_empty -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesSecretV1Data_empty
=== PAUSE TestAccKubernetesSecretV1Data_empty
=== CONT  TestAccKubernetesSecretV1Data_empty
--- PASS: TestAccKubernetesSecretV1Data_empty (7.52s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   8.472s
(base) ┌─(~/Dev/terraform-provider-kubernetes)─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────(mau@mau-JKDT676NCP:s002)─┐
└─(11:56:05 on secretV1Data)──> make testacc TESTARGS='-run TestAccKubernetesSecretV1Data_basic_data'                                                                                                                                                                                   ──(Thu,Oct17)─┘
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -vet=off -run TestAccKubernetesSecretV1Data_basic_data -parallel 8 -timeout 3h
=== RUN   TestAccKubernetesSecretV1Data_basic_data
=== PAUSE TestAccKubernetesSecretV1Data_basic_data
=== CONT  TestAccKubernetesSecretV1Data_basic_data
--- PASS: TestAccKubernetesSecretV1Data_basic_data (6.64s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   7.540s
(base) ┌─(~/Dev/terraform-provider-kubernetes)─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────(mau@mau-JKDT676NCP:s002)─┐
└─(12:03:46 on secretV1Data)──> make testacc TESTARGS='-run TestAcctKubernetesSecretV1Data_modified'                                                                                                                                                                                    ──(Thu,Oct17)─┘
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -vet=off -run TestAcctKubernetesSecretV1Data_modified -parallel 8 -timeout 3h
testing: warning: no tests to run
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   0.952s [no tests to run]
(base) ┌─(~/Dev/terraform-provider-kubernetes)─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────(mau@mau-JKDT676NCP:s002)─┐
└─(12:03:15 on secretV1Data)──> make testacc TESTARGS='-run TestAcctKubernetesSecretV1Data_validation'                                                                                                                                                                                  ──(Thu,Oct17)─┘
==> Checking that code complies with gofmt requirements...
go vet ./...
TF_ACC=1 go test "/Users/mau/Dev/terraform-provider-kubernetes/kubernetes" -v -vet=off -run TestAcctKubernetesSecretV1Data_validation -parallel 8 -timeout 3h
=== RUN   TestAcctKubernetesSecretV1Data_validation
=== PAUSE TestAcctKubernetesSecretV1Data_validation
=== CONT  TestAcctKubernetesSecretV1Data_validation
--- PASS: TestAcctKubernetesSecretV1Data_validation (2.93s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   3.890s

Release Note

Release note for CHANGELOG:

Adding the `kubernetes_secret_v1_data` resource to the kubernetes provider. This resource will allow users to manage kubernetes secrets

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link

hashicorp-cla-app bot commented May 23, 2024

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


2 out of 3 committers have signed the CLA.

  • JaylonmcShan03
  • BBBmau
  • Jaylon McShan

Jaylon McShan seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Jaylon McShan seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

…the test file for the resource, and added the resource in the resource map
@github-actions github-actions bot added size/XL and removed size/M labels May 24, 2024
@JaylonmcShan03 JaylonmcShan03 marked this pull request as ready for review May 24, 2024 17:33
@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner May 24, 2024 17:33
@BBBmau BBBmau added this to the v2.23.0 milestone Aug 14, 2024
@BBBmau BBBmau modified the milestones: v2.33.0, v2.34.0 Oct 10, 2024
@BBBmau BBBmau added the no-documentation This issue or pull request does not have documentation changes. label Oct 17, 2024
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the description to include the tests that i ran locally as well as the output.

Latest commit just does some minor cleanup such as removing commented out code and reverting a line removal in a file that isn't related to the PR changes.

All looks good!

@BBBmau BBBmau removed this from the v2.34.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-documentation This issue or pull request does not have documentation changes. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config_map_v1_data same for secret_v1_data
2 participants