Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: error msgs #494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: error msgs #494

wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Collaborator

Error messages should not begin with capitalization or end with punctuation.

@tenthirtyam tenthirtyam added this to the v1.5.0 milestone Dec 1, 2024
@tenthirtyam tenthirtyam self-assigned this Dec 1, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner December 1, 2024 19:56
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits on some comments, mostly to steer users towards a resolution in some cases, but besides that this LGTM!

builder/vsphere/driver/datastore.go Outdated Show resolved Hide resolved
builder/vsphere/driver/vm.go Outdated Show resolved Hide resolved
builder/vsphere/driver/vm.go Outdated Show resolved Hide resolved
Error messages should not begin with capitalization or end with punctuation.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam
Copy link
Collaborator Author

@lbajolet-hashicorp - ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants