Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF-23534] Fix test panic #1042

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[TF-23534] Fix test panic #1042

merged 1 commit into from
Jan 22, 2025

Conversation

natalie-todd
Copy link
Contributor

Description

A new test with a panic was introduced in #1030. This PR fixes the panic by removing the nil pointer dereference causing it. In the coming weeks there will be a follow up PR which will support the comparison of the architectures returned by the terraform versions CREATE endpoint.

@natalie-todd natalie-todd requested a review from a team as a code owner January 22, 2025 17:38
Copy link
Collaborator

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@datadog-terraform-cloud-hashicorp

Datadog Report

Branch report: ntodd/tf-23534/fix-test-panic
Commit report: a74ec32
Test service: hashicorp/go-tfe

✅ 0 Failed, 1421 Passed, 162 Skipped, 18m 23.01s Total Time
➡️ Test Sessions change in coverage: 1 no change

@natalie-todd natalie-todd merged commit 1196500 into main Jan 22, 2025
8 checks passed
@natalie-todd natalie-todd deleted the ntodd/tf-23534/fix-test-panic branch January 22, 2025 19:31
Copy link

Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants