Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

212 add group transaction #587

Merged
merged 32 commits into from
Aug 20, 2024
Merged

212 add group transaction #587

merged 32 commits into from
Aug 20, 2024

Conversation

Sheng-Long
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Sheng-Long Sheng-Long changed the title 212 add group transaction WIP: 212 add group transaction Jun 26, 2024
@Sheng-Long Sheng-Long changed the title WIP: 212 add group transaction 212 add group transaction Jun 26, 2024
@Sheng-Long Sheng-Long marked this pull request as draft June 26, 2024 10:54
@Sheng-Long Sheng-Long force-pushed the 212-add-group-transaction branch 2 times, most recently from f67acb9 to 930fa22 Compare July 1, 2024 20:23
@Sheng-Long Sheng-Long marked this pull request as ready for review July 3, 2024 03:30
@Sheng-Long Sheng-Long force-pushed the 212-add-group-transaction branch 10 times, most recently from d01f8aa to 7b3ba7d Compare July 10, 2024 20:57
@Sheng-Long Sheng-Long force-pushed the 212-add-group-transaction branch 2 times, most recently from 33eeb36 to 0621a87 Compare July 17, 2024 04:51
@RAMTO RAMTO closed this Jul 18, 2024
@Sheng-Long Sheng-Long reopened this Jul 18, 2024
@RAMTO RAMTO closed this Jul 23, 2024
@Sheng-Long
Copy link
Contributor Author

State is kept when we leave group creation with all populated tx's.

Description: When we start creating a group and for some reason we abandon it, the next time we land on the group creation we have the old populated transactions from last time.

1. Click on Create New->Transaction Group

2. Add several transactions

3. Leave group creation window

4. Navigate again to Transaction page

5. Click on Create New->Transaction Group

2024-07-22.12-07-05.mp4

This is intended behavior. I'd assume users would be more upset for accidentally navigating away and losing any work than clicking the delete button a few times.

@Sheng-Long
Copy link
Contributor Author

Sheng-Long commented Jul 24, 2024

Sending a tx in a group results in invalid signature error

1. Click on Create New->Transaction Group

2. Click on Add transaction

3. Select "Create Account" tx

4. Click on "Add to Group" button

5. Click on "Sign&Execute" button

2024-07-22.11-49-42.mp4

Unable to replicate this issue, more information is needed

@Sheng-Long
Copy link
Contributor Author

All issues addressed

@Sheng-Long Sheng-Long reopened this Jul 24, 2024
Sheng-Long and others added 20 commits August 19, 2024 17:03
Signed-off-by: Tim Schmidt <[email protected]>
… if navigating away from creategroup

Signed-off-by: Tim Schmidt <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
Signed-off-by: Svetoslav Borislavov <[email protected]>
…to signature, add modal for empty transactions but filled description, clear data in organization groups after submission

Signed-off-by: Tim Schmidt <[email protected]>
@RAMTO RAMTO force-pushed the 212-add-group-transaction branch from 62b083c to d484202 Compare August 19, 2024 14:03
Copy link

codecov bot commented Aug 19, 2024

The author of this PR, Sheng-Long, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

Signed-off-by: Martin Dobrev <[email protected]>
@RAMTO RAMTO merged commit f0b4ceb into main Aug 20, 2024
12 of 15 checks passed
@RAMTO RAMTO deleted the 212-add-group-transaction branch August 20, 2024 10:40
@SimiHunjan SimiHunjan linked an issue Aug 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add group transactions
4 participants