Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow creation of sign-only transactions and export them #1440

Merged
merged 46 commits into from
Jan 14, 2025
Merged

feat: allow creation of sign-only transactions and export them #1440

merged 46 commits into from
Jan 14, 2025

Conversation

SvetBorislavov
Copy link
Contributor

Description:
This pull request:

  • adds transaction statuses to create a transaction that won't be executed.
  • adds an export button so that users can export transaction files and deserialize them in other applications

Related issue(s):

Fixes #
#1208

Checklist

  • Tested

@SvetBorislavov
feat: add SIGN_ONLY and ARCHIVED transaction statuses
8b912ab 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
faet: add error code for Transaction archived
1c51c18 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: integrate sign only in existing flows
e7263a6 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: back-end e2e tests
e648321 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add endpoints for mark as sign-only and archiving
db87679 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: typo
b367a21 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: back-end tests
b833640 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add error code for archiving sign-only transactions
bc2a1cf 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: update notification system to support sign only and archives
8400741 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
style: move import
1c96213 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: extend getTransactionType util
6682692 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
refactor: divide TransactionDetails component
58669b3 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
refactor: fix name of AppSelect
9290625 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: create AppDropDown
efbe5c8 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add dropdown
b5e954d 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: limit visible buttons to two
23800cc 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: support sign-only upon transaction creation in BE
233571a 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: submit transaction in FE accepts isSignOnly
91a80e2 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add is sign-only checkbox in the header
6e9fe85 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: execution of sign-only tx
2a7ba52 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: update checks for sending signatures and approvals
36b8295 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: unit tests
957172b 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: allow creating sign-only expired transactions
a4bac7b 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add e2e test for signing expired sign-only transaction
6eee048 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: update buttons arrangement
9f4a0e8 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add AppDropDown mode
9f7b3aa 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: use compact mode in transaction details
57bf938 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: required keys functions
d448d6a 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: make header buttons loading smoother
35f0cf5 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: remove only with valid validStart restriction
f659251 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add archive action in transaction details
6676ac4 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: status label in History
40d9c96 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: adjust details stepper to support new features
2656ad7 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add mark as sign-only handler
49ebf4f 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
refator: common handlers
8bea828 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add export feature for transactions
8ac7fcb 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add tests for saveFileNamed
70e1d9a 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add data-testids to transaction details header buttons
31f7485 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: add tooltip for the is sign-only checkbox
9b2c539 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
feat: remove navigation when changing modes
5c05e1f 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov SvetBorislavov requested review from yiliev0 and a team as code owners January 13, 2025 09:22
SvetBorislavov and others added 6 commits January 13, 2025 11:29
@SvetBorislavov
feat: remove unnecessary test
88e3c71 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: typecheck
b5891b3 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: details stepper
8e66cad 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@SvetBorislavov
fix: group action modal
3c51f16 
Signed-off-by: Svetoslav Borislavov <[email protected]>
@yiliev0
test: Fix failing notification test
b1566a1 
Signed-off-by: Yordan Iliev <[email protected]>
@yiliev0
test: Fix concurrency problem in tests
8360770 
Signed-off-by: Yordan Iliev <[email protected]>
@jsync-swirlds jsync-swirlds requested review from jbair06 and removed request for jsync-swirlds January 13, 2025 15:42
@SvetBorislavov SvetBorislavov merged commit 9198cf1 into main Jan 14, 2025
15 checks passed
@SvetBorislavov SvetBorislavov deleted the feat-add-transaction-export branch January 14, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbair06 jbair06 jbair06 approved these changes

@yiliev0 yiliev0 yiliev0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SvetBorislavov @jbair06 @yiliev0