Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial fees and throttles for Hip 551 batch transactions #17392

Open
wants to merge 6 commits into
base: hip-551-hapi-verbs
Choose a base branch
from

Conversation

ibankov
Copy link
Contributor

@ibankov ibankov commented Jan 15, 2025

Description:
Adding fees and throttles for HIP 551 (Batch Transactions). The current values are placeholders until we have the final fees/throttles

Related issue(s):
#17373
#17374
Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ibankov ibankov added this to the v0.60 milestone Jan 15, 2025
@ibankov ibankov self-assigned this Jan 15, 2025
Signed-off-by: ibankov <[email protected]>
Copy link

codacy-production bot commented Jan 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a8f4fba) 96472 69076 71.60%
Head commit (5bf4070) 96477 (+5) 69078 (+2) 71.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17392) 5 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (290a506) to head (f595ed6).

Files with missing lines Patch % Lines
...service/util/impl/handlers/AtomicBatchHandler.java 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             hip-551-hapi-verbs   #17392      +/-   ##
========================================================
- Coverage                 67.72%   67.72%   -0.01%     
+ Complexity                22203    22202       -1     
========================================================
  Files                      2596     2596              
  Lines                     96689    96694       +5     
  Branches                  10082    10082              
========================================================
- Hits                      65486    65485       -1     
- Misses                    27459    27464       +5     
- Partials                   3744     3745       +1     
Files with missing lines Coverage Δ
...service/util/impl/handlers/AtomicBatchHandler.java 11.76% <0.00%> (-4.91%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip551/AtomicBatchTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the throttle configuration Implement the calculateFees() method
1 participant