Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace pnpm/action-setup with a step-security maintained one #822

Conversation

PavelSBorisov
Copy link
Member

Description

pnpm/action-setup has to be replaced with a variant maintained by step-security in all workflows utilizing the action.

Related Issues

@PavelSBorisov PavelSBorisov added the github_actions Pull requests that update GitHub Actions code label Nov 28, 2024
@PavelSBorisov PavelSBorisov self-assigned this Nov 28, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners November 28, 2024 13:34
Copy link

Wallet Snap Unit Test Results

193 tests  ±0   193 ✅ ±0   1m 36s ⏱️ -2s
  7 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0dee5d6. ± Comparison against base commit c8e94d6.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c8e94d6) 960 457 47.60%
Head commit (0dee5d6) 960 (+0) 457 (+0) 47.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#822) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.23%. Comparing base (c8e94d6) to head (0dee5d6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   49.23%   49.23%           
=======================================
  Files          12       12           
  Lines        1312     1312           
  Branches      454      454           
=======================================
  Hits          646      646           
  Misses        618      618           
  Partials       48       48           

Impacted file tree graph

Copy link

@san-est san-est left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PavelSBorisov PavelSBorisov merged commit 865076c into main Dec 2, 2024
14 checks passed
@PavelSBorisov PavelSBorisov deleted the 821-chore-replace-pnpmaction-setup-with-one-maintained-by-step-security branch December 2, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Replace pnpm/action-setup with one maintained by step-security
3 participants