Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhanced eth_getLogs with timestamp range validation and new error handling #3431

fix: threw INVALID_BLOCK_RANGE if fromBlockNum is greater than toBloc…

6b90c41
Select commit
Loading
Failed to load commit list.
Merged

feat: enhanced eth_getLogs with timestamp range validation and new error handling #3431

fix: threw INVALID_BLOCK_RANGE if fromBlockNum is greater than toBloc…
6b90c41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

85.35% (target 80.00%)

View this Pull Request on Codecov

85.35% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (373f1dc) to head (6b90c41).

Files with missing lines Patch % Lines
.../lib/services/ethService/ethCommonService/index.ts 94.11% 0 Missing and 2 partials ⚠️
.../lib/services/ethService/ethFilterService/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3431      +/-   ##
==========================================
+ Coverage   84.18%   85.35%   +1.16%     
==========================================
  Files          69       69              
  Lines        4711     4738      +27     
  Branches     1048     1056       +8     
==========================================
+ Hits         3966     4044      +78     
+ Misses        428      394      -34     
+ Partials      317      300      -17     
Files with missing lines Coverage Δ
packages/relay/src/lib/errors/JsonRpcError.ts 75.00% <100.00%> (+0.49%) ⬆️
packages/relay/src/lib/eth.ts 86.11% <ø> (+4.84%) ⬆️
.../lib/services/ethService/ethFilterService/index.ts 80.43% <0.00%> (-2.18%) ⬇️
.../lib/services/ethService/ethCommonService/index.ts 91.46% <94.11%> (+0.15%) ⬆️

... and 4 files with indirect coverage changes