Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhanced eth_getLogs with timestamp range validation and new error handling #3431

Merged
merged 11 commits into from
Jan 29, 2025

fix: threw INVALID_BLOCK_RANGE if fromBlockNum is greater than toBloc…

6b90c41
Select commit
Loading
Failed to load commit list.
Refresh
Sign in for the full log view
Merged

feat: enhanced eth_getLogs with timestamp range validation and new error handling #3431

fix: threw INVALID_BLOCK_RANGE if fromBlockNum is greater than toBloc…
6b90c41
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results failed Jan 28, 2025 in 0s

10 fail, 67 pass in 18m 46s

  3 files   -  19   27 suites   - 325   18m 46s ⏱️ - 29m 49s
 77 tests  - 539   67 ✅  - 538  0 💤  - 4  10 ❌ +3 
228 runs   - 586  214 ✅  - 587  0 💤  - 6  14 ❌ +7 

Results for commit 6b90c41. ± Comparison against earlier commit d8743aa.

Annotations

Check warning on line 0 in should execute "eth_sendRawTransaction" and deploy a contract with any arbitrary calldata size

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…th any arbitrary calldata size (should execute "eth_sendRawTransaction" and deploy a contract with any arbitrary calldata size) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 27s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in should delete the file created while execute "eth_sendRawTransaction" to deploy a large contract

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…" to deploy a large contract (should delete the file created while execute "eth_sendRawTransaction" to deploy a large contract) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 16s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in should execute "eth_sendRawTransaction" of type 1 and deploy a real contract

See this annotation in the file changed.

@github-actions github-actions / Test Results

2 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…ransaction" of type 1 and deploy a real contract (should execute "eth_sendRawTransaction" of type 1 and deploy a real contract) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 15s]
test-results.d5a444ac783d28ee55a8c8d62f1a915b.xml [took 15s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in should execute "eth_sendRawTransaction" of type 2 and deploy a real contract

See this annotation in the file changed.

@github-actions github-actions / Test Results

2 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…ransaction" of type 2 and deploy a real contract (should execute "eth_sendRawTransaction" of type 2 and deploy a real contract) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 15s]
test-results.d5a444ac783d28ee55a8c8d62f1a915b.xml [took 15s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in should execute "eth_sendRawTransaction" and deploy a contract with more than 2 HBAR transaction fee and less than max transaction fee

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…execute "eth_sendRawTransaction" and deploy a contract with more than 2 HBAR transaction fee and less than max transaction fee) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 15s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in @release should execute "eth_getTransactionByHash" for existing transaction

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…th_getTransactionByHash" for existing transaction (@release should execute "eth_getTransactionByHash" for existing transaction) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 15s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in @release fail "eth_getTransactionReceipt" on precheck with wrong nonce error when sending a tx with the same nonce twice

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…wice (@release fail "eth_getTransactionReceipt" on precheck with wrong nonce error when sending a tx with the same nonce twice) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 15s]
Raw output 
Request failed with status code 404
AxiosError: Request failed with status code 404
    at settle (node_modules/axios/lib/core/settle.js:19:12)
    at IncomingMessage.handleStreamEnd (node_modules/axios/lib/adapters/http.js:599:11)
    at IncomingMessage.emit (node:events:530:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:40:14)
    at Axios.request (node_modules/axios/lib/core/Axios.js:45:41)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check warning on line 0 in @release fail "eth_getTransactionReceipt" on submitting with wrong nonce error when sending a tx with the same nonce twice

See this annotation in the file changed.

@github-actions github-actions / Test Results

1 out of 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Accept…ce (@release fail "eth_getTransactionReceipt" on submitting with wrong nonce error when sending a tx with the same nonce twice) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 4m 0s]
Raw output 
Timeout of 240000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/_work/hedera-json-rpc-relay/hedera-json-rpc-relay/packages/server/tests/acceptance/index.spec.ts)
Error: Timeout of 240000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/_work/hedera-json-rpc-relay/hedera-json-rpc-relay/packages/server/tests/acceptance/index.spec.ts)
    at listOnTimeout (node:internal/timers:581:17)
    at processTimers (node:internal/timers:519:7)

Check warning on line 0 in should execute "eth_sendRawTransaction" if receiver's account has receiver_sig_required disabled

See this annotation in the file changed.

@github-actions github-actions / Test Results

All 3 runs failed: RPC Server Acceptance Tests Acceptance tests @api-batch-1 RPC Server Acceptance Tests RPC Server Acceptance …ceiver_sig_required disabled (should execute "eth_sendRawTransaction" if receiver's account has receiver_sig_required disabled) 

test-results.8bc29bc9005fe5753bfd2ea42d3ececb.xml [took 4m 0s]
test-results.a817ef696fb0f21840e084ad57e9f09e.xml [took 4m 0s]
test-results.d5a444ac783d28ee55a8c8d62f1a915b.xml [took 0s]
Raw output 
transaction must have been frozen before calculating the hash will be stable, try calling `freeze`
Error: transaction must have been frozen before calculating the hash will be stable, try calling `freeze`
    at AccountCreateTransaction._requireFrozen (packages/server/node_modules/@hashgraph/sdk/lib/transaction/Transaction.cjs:1550:13)
    at AccountCreateTransaction.signWith (packages/server/node_modules/@hashgraph/sdk/lib/transaction/Transaction.cjs:621:12)
    at AccountCreateTransaction.sign (packages/server/node_modules/@hashgraph/sdk/lib/transaction/Transaction.cjs:602:17)
    at Context.<anonymous> (packages/server/tests/acceptance/rpc_batch1.spec.ts:1665:14)
    at Generator.next (<anonymous>)
    at /home/runner/_work/hedera-json-rpc-relay/hedera-json-rpc-relay/packages/server/tests/acceptance/rpc_batch1.spec.ts:27:71
    at new Promise (<anonymous>)
    at __awaiter (packages/server/tests/acceptance/rpc_batch1.spec.ts:23:12)
    at Context.<anonymous> (packages/server/tests/acceptance/rpc_batch1.spec.ts:1154:32)
    at processImmediate (node:internal/timers:483:21)

Check warning on line 0 in "after all" hook in "RPC Server Acceptance Tests"

See this annotation in the file changed.

@github-actions github-actions / Test Results

RPC Server Acceptance Tests "after all" hook in "RPC Server Acceptance Tests" ("after all" hook in "RPC Server Acceptance Tests") failed 

test-results.d5a444ac783d28ee55a8c8d62f1a915b.xml [took 0s]
Raw output 
failed to find a healthy working node
Error: failed to find a healthy working node
    at Network.getNode (packages/server/node_modules/@hashgraph/sdk/lib/client/ManagedNetwork.cjs:416:15)
    at AccountBalanceQuery.execute (packages/server/node_modules/@hashgraph/sdk/lib/Executable.cjs:583:32)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
View more details on GitHub Actions