Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check volume sources and attachment #1186

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Check volume sources and attachment #1186

merged 2 commits into from
Mar 26, 2024

Conversation

albinsun
Copy link
Contributor

Changes

  1. Add volume source paramter, includes "New" and "VM Image".
  2. Add checks on
    • attachment by harvesterhci.io/owned-by annotation
    • source by harvesterhci.io/imageId annotation

Verification

harvester-runtests/475
image

lanfon72
lanfon72 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@lanfon72 lanfon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushboo-rancher khushboo-rancher merged commit d738c41 into harvester:main Mar 26, 2024
3 checks passed
@albinsun albinsun deleted the detached_volume_status branch March 27, 2024 05:53
@lanfon72 lanfon72 mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanfon72 lanfon72 lanfon72 approved these changes

@khushboo-rancher khushboo-rancher khushboo-rancher approved these changes

@irishgordo irishgordo Awaiting requested review from irishgordo

@m-ildefons m-ildefons Awaiting requested review from m-ildefons

@TachunLin TachunLin Awaiting requested review from TachunLin

@noahgildersleeve noahgildersleeve Awaiting requested review from noahgildersleeve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albinsun @lanfon72 @khushboo-rancher