Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e] add metadata expose to test report #1109

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[e2e] add metadata expose to test report #1109

merged 1 commit into from
Feb 20, 2024

Conversation

lanfon72
Copy link
Member

Expose cluster metadata into environment section like:
image

@lanfon72 lanfon72 requested a review from a team February 19, 2024 15:16
albinsun
albinsun approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irishgordo
irishgordo approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@irishgordo irishgordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 😄 - lgtm - having the metadata will be useful if we need to jump on the cluster to take a look at something

@lanfon72 lanfon72 merged commit 37c8d4a into harvester:main Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albinsun albinsun albinsun approved these changes

@irishgordo irishgordo irishgordo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanfon72 @albinsun @irishgordo