network interact tests: fix SSH check #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix SSH connection checks There are serveral places where a test checks that an SSH connection to a VM on a specific interface can not be established. Doing so by checking for the specific error "no route to host" is potentially wrong, because this presumes that the host executing the test even knows how to route to the network. This isn't always the case, e.g. when executing the test suite on a developer workstation instead of a CI server. In those cases there may be an SSH error "network unreachable" instead, which should also be acceptable to let the test pass. To allow for this case, instead of checking the output of the SSH command for a specific substring, checking for the return code 255 is better, because it allows for different kind of errors and is less fragile than searching for a string in the command output. - Mark networking tests with @pytest.mark.networks This includes the network interaction tests when selecting tests with the pytest mark "networks" - Fix SSH connection with paramiko when the ssh agent contains keys, but password authentication is used By defaul paramiko will try to use key based authentication using whichever keys it finds in the ssh-agent. In this case however password based authentication is used and paramiko should not try to use the keys from the ssh-agent. Otherwise it may be confused and error out. Signed-off-by: Moritz Röhrich <[email protected]>
lanfon72
reviewed
Jan 22, 2024
There was a problem hiding this comment.
The change looks fine to me, but tested on harvester-runtests#459(this PR, modified) and harvester-runtests#460(original), modified get more fails.
I feel there might have some bugs inside which not caused by this change.
btw, for reviewers, we can just simply add harvester/qa team them all QAs will receive the mail to review this PR.
khushboo-rancher
approved these changes
Jan 22, 2024
|
This change worked perfectly fine for me on a clean cluster: It might be worth looking at the logs to see if there is anything damning in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSH connection checks There are serveral places where a test checks that an SSH connection to a VM on a specific interface can not be established. Doing so by checking for the specific error "no route to host" is potentially wrong, because this presumes that the host executing the test even knows how to route to the network. This isn't always the case, e.g. when executing the test suite on a developer workstation instead of a CI server. In those cases there may be an SSH error "network unreachable" instead, which should also be acceptable to let the test pass.
To allow for this case, instead of checking the output of the SSH command for a specific substring, checking for the return code 255 is better, because it allows for different kind of errors and is less fragile than searching for a string in the command output.
Mark networking tests with @pytest.mark.networks This includes the network interaction tests when selecting tests with the pytest mark "networks"
Fix SSH connection with paramiko when the ssh agent contains keys, but password authentication is used
By defaul paramiko will try to use key based authentication using whichever keys it finds in the ssh-agent. In this case however password based authentication is used and paramiko should not try to use the keys from the ssh-agent. Otherwise it may be confused and error out. This is the same problem that was fixed in networking tests: fix ssh auth, clean up code #1060 for other tests