-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RKE2 cluster by terraform #1070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge the fixture terraform_rancher.py
into fixture terraform.py
, It looks there have several duplicated fixtures and help classes.
To notice that the BaseTerraformResource
could also merge into the exist one, and the TerraformResource
should have Rancher
to distinguish with Harvester one.
There might have some naming conflict when merging, those should add rancher
to distinguish with exist one.
@albinsun, I think you would need to rebase to reduce duplicated file changes from other (merged) PRs. # in local repo
git checkout main && git pull
git checkout <this-branch>
git rebase main
# then you will need to force push to update the PR
git push -f |
a9d0964
to
cf6ff50
Compare
@lanfon72, done, thanks for ur comment, will use rebase instead of merge then. |
Changes
Specify rancher provider version by
config.yml
:terraform-provider-rancher
3.1.1
as default value due to a known issue [BUG] 3.2.0 version, docs for harvester provider are still showing that config in machine_selector_config is a map rancher/terraform-provider-rancher2#1284Add TCs for RKE2 cluster using terraform rancher provider1, includes:
rancher2_cloud_credential
resourcerancher2_machine_config_v2
resourcerancher2_cluster_v2
resourceVerification
harvester-runtests/461
using-k test_z_terraform
Footnotes
https://github.com/rancher/terraform-provider-rancher2/tree/v3.1.1/docs/resources ↩