[e2e] change test case orders #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsun
reviewed
Jan 17, 2024
| | ------ | -------- | ----------- | | ||
| | z | Terraform | Fixed for terraform related test cases | | ||
| | 9 | Rancher | Fixed number for external Rancher integration | | ||
| | 0 | Settings | Any settings could be tested individually if not interact with others | |
There was a problem hiding this comment.
Better to list table in real order: test_[0-9]_* then test_[a-z]_*.
There was a problem hiding this comment.
Let's change terraform to 9 and move rancher + terraform to scenarios, WDYT?
and let's also change integration to integrations.
There was a problem hiding this comment.
It's reasonable to rename integration to integrations.
For test cases classification, It's ok as longs as we have clear definition in
Line 85 in fafe470
integration and scenario.
lanfon72
force-pushed
the
e2e-rework
branch
3 times, most recently
from
843c069 to
1279196
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes