Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: update copyright to 2024 #72

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Vicente-Cheng
Copy link
Collaborator

Problem:
Validation failure due to copyright not matching.

Solution:
update copyright

Related Issue:

Test plan:
Just make sure the CI passed

@Vicente-Cheng Vicente-Cheng requested review from tserong and bk201 January 2, 2024 11:50
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm curious though - where can I see the failed validation that necessitated this change?

@Vicente-Cheng
Copy link
Collaborator Author

Vicente-Cheng commented Jan 3, 2024

LGTM. I'm curious though - where can I see the failed validation that necessitated this change?

The validate-ci will check the generated code should be the same as the current one. If not, it will return an error.

If you use make to trigger dapper, it will not run into this. Use dapper; it will run with this.

@tserong
Copy link
Contributor

tserong commented Jan 3, 2024

Got it, thanks @Vicente-Cheng!

@Vicente-Cheng Vicente-Cheng merged commit 05c9741 into harvester:master Jan 3, 2024
8 checks passed
@Vicente-Cheng
Copy link
Collaborator Author

@Mergifyio backport v0.5.x

@Vicente-Cheng
Copy link
Collaborator Author

@Mergifyio backport v0.6.x

Copy link

mergify bot commented Jan 3, 2024

backport v0.5.x

✅ Backports have been created

Copy link

mergify bot commented Jan 3, 2024

backport v0.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants