-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set LHv2 DiskDriver to "auto" if unset #152
Conversation
We need to force DiskDriver to "auto" if it's not explicitly set, because Longhorn also does that internally. If we don't do this, the subsequent reflect.DeepEqual() in LonghornV2Provisioner.Update() will always fail because we have an empty string, but the LHN CR will have it set to "auto" which results in a weird resync loop. Related issue: harvester/harvester#6709 Signed-off-by: Tim Serong <[email protected]>
harvester/vagrant-k3s#3 should fix that CI failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
latest CI failure is:
I suspect this is probably because |
Yeah, and it should be fixed on #151. I thought we could merge it and let CI re-run with the master branch |
Problem:
We need to force DiskDriver to "auto" if it's not explicitly set, because Longhorn also does that internally. If we don't do this, the subsequent
reflect.DeepEqual()
inLonghornV2Provisioner.Update()
will always fail because we have an empty string, but the LHN CR will have it set to "auto" which results in a weird resync loop.Solution:
This PR.
Related Issue:
harvester/harvester#6709
Test plan:
Add an LHv2 disk. Verify we don't see the errors mentioned in the related issue.