Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor tweaks #110

Merged
merged 3 commits into from
Jun 18, 2024
Merged

A few minor tweaks #110

merged 3 commits into from
Jun 18, 2024

Conversation

tserong
Copy link
Contributor

@tserong tserong commented Jun 17, 2024

Problem:
I want to add some more details to the README file, a comment about how the version gets set during build, and fix a tiny bit of debug logging.

Solution:
This PR

Related Issue:
N/A

Test plan:
N/A

@tserong tserong requested a review from Vicente-Cheng June 17, 2024 08:23
Copy link
Collaborator

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement!

@Vicente-Cheng Vicente-Cheng requested a review from bk201 June 18, 2024 06:42
@Vicente-Cheng Vicente-Cheng merged commit 1cc84e8 into harvester:master Jun 18, 2024
7 checks passed
@tserong tserong deleted the wip-minor-works branch June 18, 2024 08:36
@Vicente-Cheng
Copy link
Collaborator

@Mergifyio backport v0.5.x v0.6.x

Copy link

mergify bot commented Jun 20, 2024

backport v0.5.x v0.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants