Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KB: Clarify the impacted version of filesystem trim #63

Merged

Conversation

Vicente-Cheng
Copy link
Contributor

Add a form to clarify the impacted version

Copy link

netlify bot commented May 31, 2024

Deploy Preview for harvester-home-preview ready!

Name Link
🔨 Latest commit a8f2629
🔍 Latest deploy log https://app.netlify.com/sites/harvester-home-preview/deploys/665e77dd2155fc0008788fba
😎 Deploy Preview https://deploy-preview-63--harvester-home-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vicente-Cheng Vicente-Cheng force-pushed the clarify-impacted-version branch 2 times, most recently from 3f53e4c to 7589c43 Compare May 31, 2024 16:53
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vicente-Cheng @bk201 Please check my suggestions.

kb/2024-01-30/the_potential_risk_with_fstrim.md Outdated Show resolved Hide resolved
@Vicente-Cheng Vicente-Cheng force-pushed the clarify-impacted-version branch 2 times, most recently from 801cc13 to 21c3a2f Compare June 3, 2024 16:17
@Vicente-Cheng
Copy link
Contributor Author

Thanks for the suggestion!

Updated!

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: Vicente Cheng <[email protected]>
Co-authored-by: Kiefer Chang <[email protected]>
Co-authored-by: Jillian <[email protected]>
@Vicente-Cheng Vicente-Cheng force-pushed the clarify-impacted-version branch from 21c3a2f to a8f2629 Compare June 4, 2024 02:11
@Vicente-Cheng
Copy link
Contributor Author

Just add Co-authored-by: with the latest update.

@Vicente-Cheng Vicente-Cheng merged commit 2264312 into harvester:main Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants