Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to resume /active vm schedule job (backport #69) #75

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 10, 2025

Summary

There is a sudden harvesterhci.io.schedulevmbackup websocket changes data object missing metadata.state.name.

See
Screenshot 2025-01-08 at 2 55 06 PM

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue

harvester/harvester#7174

Test screenshot/video

Screen.Recording.2025-01-08.at.4.00.47.PM.mov

Extra technical notes summary

After synced with @WebberHuang1118 , we can consume status.suspended = true to determine schedule job is suspended or not. There is no other status for schedule job so far.

We can enhance get state() if backend has other status in the future.

Screenshot 2025-01-08 at 3 49 15 PM

see HEP : https://github.com/harvester/harvester/blob/master/enhancements/20240611-vm-schedule-backup.md#crd

status.suspended presents if the schedule is suspended
```<hr>This is an automatic backport of pull request #69 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <[email protected]>
(cherry picked from commit 814d296)
@a110605 a110605 merged commit 90b85d2 into release-harvester-v1.5 Jan 10, 2025
2 checks passed
@a110605 a110605 deleted the mergify/bp/release-harvester-v1.5/pr-69 branch January 10, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant