Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add confirmation pop-up for VM stop and pause actions (backport #94) #102

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 21, 2025

Summary

  • A confirmation pop-up should display when the Stop or Pause action is clicked
  • Mac users can bypass the confirmation pop-up by holding the Command key while clicking the action

PR Checklists

  • Do we need to backport this PR change to the Harvester Dashboard?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue

[ENHANCEMENT] Add confirmation pop-up for VM stop and pause actions #7382

Test screenshot/video

Confirm pop-up for stop VM
stop

Confirm pop-up for stop multi VMs
Screenshot 2025-01-20 at 12 17 52 PM (2)

Confirm pop-up for pause VM
pause

Extra technical notes summary

N/A


This is an automatic backport of pull request #94 done by [Mergify](https://mergify.com).

Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit 526d1bb)
Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit fdc6359)
Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit f2d5172)
Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit c4e9a89)
@houhoucoop houhoucoop merged commit 8d338b5 into release-harvester-v1.5 Jan 21, 2025
2 checks passed
@houhoucoop houhoucoop deleted the mergify/bp/release-harvester-v1.5/pr-94 branch January 21, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant