fix: cluster member role user should not be able to delete node on Harvester Hosts page (backport #83) #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Yi-Ya Chen <[email protected]> (cherry picked from commit c791399)
Signed-off-by: Yi-Ya Chen <[email protected]> (cherry picked from commit 43b10b2)
Signed-off-by: Yi-Ya Chen <[email protected]> (cherry picked from commit 3565b44)
Signed-off-by: Yi-Ya Chen <[email protected]> (cherry picked from commit f5961f3)
Signed-off-by: Yi-Ya Chen <[email protected]> (cherry picked from commit e95955f)
houhoucoop
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For security concern, cluster member role user should not be able to delete node on Harvester Hosts page.
PR Checklists
Related Issue
[BUG] Cluster member role user should not be able to delete node on Harvester Hosts page on Rancher managed Harvester #7255
Test screenshots/videos
Multi-node
Log in as
admin:Log in as
project-member:Standalone mode (only
adminlogin available):Single-node
Integration mode:
Standalone mode:
Extra technical notes summary
Test with
API=https://rancher.192.168.0.141.sslip.io yarn devThis is an automatic backport of pull request #83 done by [Mergify](https://mergify.com).