update rbac requirements for vm-import-controller #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrokethecloud
force-pushed
the
vm-import-controller-v0.4.0
branch
from
7e2f56a to
314288b
Compare
starbops
reviewed
Aug 2, 2024
ibrokethecloud
force-pushed
the
vm-import-controller-v0.4.0
branch
from
314288b to
06868ed
Compare
tserong
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR harvester/vm-import-controller#31 allows end users to specify a custom storage class during the import process.
To allow lookup of storage class the vm-import-controller now needs access to get and list storageclass objects in the cluster.
The PR adds the additional permissions needed for the same.