Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter/cufe #214

Merged
merged 13 commits into from
Nov 6, 2023
Merged

Filter/cufe #214

merged 13 commits into from
Nov 6, 2023

Conversation

ZiaddAhmedd
Copy link
Contributor

team name: cufe

results/yfcc-10M.png Outdated Show resolved Hide resolved
@@ -28,6 +28,8 @@ jobs:
dataset: random-xs
track: ood
- algorithm: cufe
dataset: random-s
track: filter
dataset: sparse-small
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a separate entry for cufe filter and cufe sparse

@harsha-simhadri
Copy link
Owner

Are these results as expected

cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 4, 'mt_threshold': 0.0001}))",yfcc-10M,10,7005.467777167178,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.721955
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 4, 'mt_threshold': 0.0003}))",yfcc-10M,10,6284.524075676667,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.762003
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 10, 'mt_threshold': 0.0001}))",yfcc-10M,10,5312.795862267859,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.826379
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 8, 'mt_threshold': 0.0003}))",yfcc-10M,10,5245.602730097057,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.8361879999999999
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 12, 'mt_threshold': 0.0002}))",yfcc-10M,10,4755.515456714368,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.8609640000000001
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 16, 'mt_threshold': 0.0001}))",yfcc-10M,10,4238.071924951995,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.870327
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 16, 'mt_threshold': 0.0003}))",yfcc-10M,10,4033.9051602997056,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.896015
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 16, 'mt_threshold': 0.00033}))",yfcc-10M,10,4013.6914950453065,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.8986319999999999
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 30, 'mt_threshold': 0.00033}))",yfcc-10M,10,2917.1327145073938,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.937862
cufe,"Faiss(('IVF4096,SQ8', {'nprobe': 32, 'mt_threshold': 0.00033}))",yfcc-10M,10,2806.7763921147266,0.0,554.1706802845001,4980820.0,0.0,0.0,filter,0.9411630000000001

@AbdelrahmanMohamed129
Copy link
Contributor

no thats not the expected output can i make a modification?

@harsha-simhadri
Copy link
Owner

@AbdelrahmanMohamed129 Please do not change the parameters after the submission deadline. That is unfair to other participants. Please limit any changes to small code fixes

@AbdelrahmanMohamed129
Copy link
Contributor

I apologize I was unaware of that rule. What should I do now?

@maumueller
Copy link
Collaborator

maumueller commented Nov 3, 2023

@AbdelrahmanMohamed129 Please remove your latest commit from this branch.

Add more details about why the results posted by Harsha are "not expected".

@ZiaddAhmedd
Copy link
Contributor Author

@AbdelrahmanMohamed129 Please remove your latest commit from this branch.

Add more details about why the results posted by Harsha are "not expected".

@maumueller I reverted the commit of changing parameters and I just fixed the problem with neurips23.yml.
The results were too far from the expected I guess because machine specifications, but we were using the suggested machine from AWS.

@ZiaddAhmedd
Copy link
Contributor Author

Is there something missing we need to do to get our submission merged?

@maumueller
Copy link
Collaborator

Alright, all CI runs are passing, I'm merging this.

@maumueller maumueller dismissed harsha-simhadri’s stale review November 6, 2023 10:33

This has be handled.

@maumueller maumueller merged commit ef195aa into harsha-simhadri:main Nov 6, 2023
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants