Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming track data_export.py bug #192

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

KhylonWong
Copy link
Contributor

Issue: the variable 'results' is being overwritten at the end of the loop, after it is potentially assigned values multiple times in the loop. Therefore, only the final result from the last runbook_path in streaming track will be considered for appending to dfs.

@maumueller
Copy link
Collaborator

Thanks @KhylonWong! I introduced that problem in 9b3a10a. I refactored your code so that the load/compute/prune chain is executed only once, I hope this improves readability of the code.

@maumueller maumueller merged commit fe38217 into harsha-simhadri:main Oct 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants