Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[ASSMT-265]: Move app-name to Migrator config. #109

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

ritek01
Copy link
Member

@ritek01 ritek01 commented Mar 18, 2024

Fix for ASSMT-265: Move app-name to Migrator Config

This pull request addresses the issue identified in ASSMT-265, where the app-name command line prompt was moved to retrieve the value from the migrator-config.yml configuration file. In cases where the value is not found in the configuration file, the CLI will prompt the user to provide the Spinnaker application name.

Additionally, this fix includes updates to ensure proper project creation with the entered organization name.

Moreover, optimizations have been made to enhance the formatting and clarity of the text messages displayed after running the CLI command.

Furthermore, the documentation has been updated to reflect these changes accurately.

A video demonstration illustrating the flow has been attached to provide clarity and transparency regarding the implemented changes.

Screen.Recording.2024-03-18.at.1.25.55.PM.mov

Copy link

@kkotula kkotula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ritek01 ritek01 merged commit 9119dcf into master Mar 18, 2024
1 check passed
@ritek01 ritek01 deleted the ASSMT-265 branch March 18, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants