-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Guide in HDH. #9529
base: main
Are you sure you want to change the base?
Style Guide in HDH. #9529
Conversation
Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67bfeff8b02095eb52c49889--harness-developer.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SushrutHarness do we really need to make it publicly available within Platform? I think It should be in general for HDH.
CC : @pratmit
Style guides are generally publicly available. Our current style guide is accessible here: https://github.com/harness/developer-hub/blob/main/CONTRIBUTING.md#style-guide. Sushrut's point is that hosting it on HDH would improve its presentation, allowing it to render nicely and display various styling options on screen. We'll wait for Prateek's input on whether the style guide can be hosted on HDH and, if so, suggest an ideal location for it. |
+1. Yeah, I noticed several platforms share guides publicly. Since these guides can be used across HDH, let's host them in a common space rather than placing them in specific modules. |
Yea I can definitely see that the "platform" section isn't the right place for it. I'm trying to figure out where it should go on HDH, and its part of the reason why I put the DO NOT MERGE label on it. Any suggestions for a good place will be greatly appreciated.
|
Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description
PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged: