Add eslint rules for i18next and prevent adding string literals in JSX

[praneshg239]

Adding eslint rules for i18next support. It prevents adding strings as JSX children.

[netlify]

✅ Deploy Preview for harness-xd-review ready!

Name	Link
🔨 Latest commit	4e334a8
🔍 Latest deploy log	https://app.netlify.com/sites/harness-xd-review/deploys/67852c1232579f0008227ba2
😎 Deploy Preview	https://deploy-preview-558--harness-xd-review.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[knagurski]

I think we'll need to set this as warn initially, otherwise we'll need to pull the brakes on everything until resolved. We'll also need to exclude apps/design-system from using these rules since it doesn't (yet) use i18n.

[praneshg239]

I think we'll need to set this as warn initially, otherwise we'll need to pull the brakes on everything until resolved. We'll also need to exclude apps/design-system from using these rules since it doesn't (yet) use i18n.

sure @knagurski. But it would be good if we keep a deadline for making all the changes to update it as error again. Any thoughts on this?

[knagurski]

I think we'll need to set this as warn initially, otherwise we'll need to pull the brakes on everything until resolved. We'll also need to exclude apps/design-system from using these rules since it doesn't (yet) use i18n.

sure @knagurski. But it would be good if we keep a deadline for making all the changes to update it as error again. Any thoughts on this?

Yeah, totally agree. We should have a work stream to extract them ASAP and guard against new strings going in until such time that we can make it an error. Earlier we make it just part of the expected standard, the less work we'll have overall.

[abhinavrastogi-harness]

something is wrong here, if adding just one package is causing 8500 lines of change in the lockfile