chore: Add unit tests for utils #1166
Conversation
✅ Deploy Preview for harness-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for harness-xd-review ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Calvin Lee <[email protected]>
Signed-off-by: Calvin Lee <[email protected]>
| removeLabelError?: string | ||
| } | ||
|
|
||
| const LabelsList: React.FC<LabelsListProps> = ({ labels, handleDelete, addLabelError, removeLabelError }) => ( |
There was a problem hiding this comment.
is this a new view being added in this PR?
is this required?
There was a problem hiding this comment.
@cjlee01 I see you added this, do we need it?
There was a problem hiding this comment.
There's a similar component here packages/ui/src/views/repo/pull-request/components/labels/pull-request-labels-list.tsx
There was a problem hiding this comment.
@cjlee1 I've removed this file for now, I see it's not used anywhere. Please add it back in a separate PR.
There was a problem hiding this comment.
I think I added then it was refactored but this reference was not used and that’s why I see duplication
@vardanbansal-harness
Enhances test coverage by adding unit tests for utility functions to improve reliability and maintainability.