Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: create project page #1134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: create project page #1134

wants to merge 1 commit into from

Conversation

andrewgolovanov
Copy link
Collaborator

  • Created a new page for project creation
  • Added a new flow of the first project creation - right after the signup
  • Сreation of the additional project also now uses the new page, but with Back button
  • Added the new page and the LandingPage to the design system
More context in the video below (38sec):
loom-video.mp4

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for harness-design ready!

Name Link
🔨 Latest commit 892927e
🔍 Latest deploy log https://app.netlify.com/sites/harness-design/deploys/67c058532c4dad0009001f41
😎 Deploy Preview https://deploy-preview-1134--harness-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 20, 2025 •
edited
Loading

✅ Deploy Preview for harness-xd-review ready!

Name Link
🔨 Latest commit 892927e
🔍 Latest deploy log https://app.netlify.com/sites/harness-xd-review/deploys/67c058530a4664000882c0cd
😎 Deploy Preview https://deploy-preview-1134--harness-xd-review.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Feb 20, 2025
Open
Closed
@andrewgolovanov andrewgolovanov linked an issue Feb 20, 2025 that may be closed by this pull request
Review Create Project #866
Open
knagurski
knagurski reviewed Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions. I'd like to avoid the noise image if possible. Someone from the implementation team would be best to sign off on the changes in apps/gitness

abhinavrastogi-harness
abhinavrastogi-harness reviewed Feb 24, 2025
View reviewed changes
apps/gitness/src/routes.tsx
{
path: 'create',
element: (
<AppProvider>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand why we need to move this out of the / wrapper which already rendered AppProvider.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We moved this out of the / wrapper because we don’t need the AppShell to be rendered with the CreateProject page. Keeping it inside would result in rendering a lot of unnecessary that are not needed for this specific page.

@ankormoreankor ankormoreankor mentioned this pull request Feb 25, 2025
Draft
@andrewgolovanov andrewgolovanov force-pushed the create-project-review branch 3 times, most recently from 75df132 to 5dfcc0b Compare February 27, 2025 12:17
knagurski
knagurski approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@knagurski knagurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion to avoid a lint warning

packages/ui/src/views/landing-page.tsx
}

export const LandingPageView: React.FC<LandingPageProps> = ({ spaces, useTranslationStore }) => {
const navigate = useNavigate()
export const LandingPageView: React.FC<LandingPageProps> = ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like React isn't imported in this file, so this will cause a lint warning. Can we directly import FC instead?

Suggested change
export const LandingPageView: React.FC<LandingPageProps> = ({
export const LandingPageView: FC<LandingPageProps> = ({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knagurski knagurski knagurski approved these changes

@abhinavrastogi-harness abhinavrastogi-harness Awaiting requested review from abhinavrastogi-harness

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Create Project
5 participants
@andrewgolovanov @CLAassistant @knagurski @abhinavrastogi-harness @ankormoreankor