[rpc] Add New RPC GetReceiptsByBlockHash for quering all receipts of the block in bulk

[AlexiaChen]

Issue

#3821

Test

No test with @hypnagonia

Local Test

• tested hmy
• tested hmyv2
• tested eth

Use RPC to comapre reponse data for same blockHash and TxHash is consistent:

curl -d '{ "jsonrpc":"2.0", "method":"hmy_getBlockByHash", "params":[ "0x73852a261acd91e6ee0b72e4b39eb3ee42ec31cfb13a5b1b0fdb676e9dbc358c", true], "id":1 }' -H "Content-Type:application/json" -X POST http://127.0.0.1:9500

response data:

data.zip

curl -d '{ "jsonrpc":"2.0", "method":"hmy_getReceiptsByBlockHash", "params":["0x73852a261acd91e6ee0b72e4b39eb3ee42ec31cfb13a5b1b0fdb676e9dbc358c"], "id":1 }' -H "Content-Type:application/json" -X POST http://127.0.0.1:9500

reponse data:

bb.zip

curl -d '{ "jsonrpc": "2.0", "method": "hmy_getTransactionReceipt", "params": [ "0xcd2634fdaaff70ab8c538e99b8cbf44ee56fd2073f54ceeeeeb9962b447691a8"], "id": 1}' -H "Content-Type:application/json" -X POST http: //127.0.0.1:9500

reponse data:

uu.zip

[JackyWYX]

I am not very sure about this design, but why can't we simply use Receipt.GasUsed? Is there anything missing here?

[AlexiaChen]

@JackyWYX

From @hypnagonia 's description, the explorer usually calls RPC GetBlocks, and GetBlocks calls GetBlockByNumber one by one from start height to end height. the information returned here does not have the usedGas of each tx. maybe @hypnagonia needs to get each tx directly from the return message here And indeed there is no similar interface like GetReceiptByTxHash, only GetReceiptsByBlockHash

[JackyWYX]

I don't understand whether there is need to modify APIs. This operation will add some extra burden to already heavily used GetBlockByNumber. Would you please add some lines of description of the necessity of modifying APIs instead of optimizing at DAPP?

[AlexiaChen]

@JackyWYX

Do you mean to add a new RPC to serve the query usedGas? Instead of putting it inside the return body of GetBlockByNumber improve payload pressure?

Actually, here's what I was thinking

• First, @hypnagonia 's original requirement is to put it in GetBlockByNumber（maybe this is necessity for explorer? ）, maybe this is more convenient for his business processing, because adding FullTx will get the usedGas list directly, adding RPC will have more changes to his explorer business code

• Second, is it really necessary to add an RPC to query the usedGas list? Because the usedGas payload is just transferred to this new RPC, the pressure on the chain's own requests may not change, because the usedGas list should not occupy much, after all, the FullTx parameters returned payload should not be small, even if the usedGas list of payload is also irrelevant

Perhaps, you have other better suggestions?

[JackyWYX]

Perhaps, you have other better suggestions?

Why don't you implement a new RPC method called GetReceiptsByBlockHash?

[AlexiaChen]

Perhaps, you have other better suggestions?

Why don't you implement a new RPC method called GetReceiptsByBlockHash?

As I mentioned above, adding a new RPC is indeed one way to do this. So it mostly depends on @hypnagonia 's needs. If he feels that this approach will not cause too many changes to his business code, I can do that.

[AlexiaChen]

Hi，@JackyWYX could you pleaese review it again？

[JasonTy]

Hi, Did the gas returned through hmy_getTransactionReceipt experience hex twice?